sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

Fix bug #7269 - Job management commands don't work for CUPS queues.

Browse Source 
Samba needs to retrieve pjob->sysjob from the CUPS response (as
is done in the iprint backend).
This commit is contained in:
Michael Karcher 2010-03-24 17:33:21 -07:00 committed by Jeremy Allison
parent 34674e0a61
commit 845c2281c7
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source3/printing/print_cups.c
View File

@ -905,6 +905,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
http_t *http = NULL; /* HTTP connection to server */
ipp_t *request = NULL, /* IPP Request */
*response = NULL; /* IPP Response */
ipp_attribute_t *attr_job_id = NULL; /* IPP Attribute "job-id" */
cups_lang_t *language = NULL; /* Default language */
char uri[HTTP_MAX_URI]; /* printer-uri attribute */
const char *clientname = NULL; /* hostname of client for job-originating-host attribute */
@ -919,7 +920,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
size_t size;
char addr[INET6_ADDRSTRLEN];
DEBUG(5,("cups_job_submit(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
DEBUG(5,("cups_job_submit(%d, %p)\n", snum, pjob));
/*
* Make sure we don't ask for passwords...
@ -1026,6 +1027,13 @@ static int cups_job_submit(int snum, struct printjob *pjob)
ippErrorString(cupsLastError())));
} else {
ret = 0;
attr_job_id = ippFindAttribute(response, "job-id", IPP_TAG_INTEGER);
if(attr_job_id) {
pjob->sysjob = attr_job_id->values[0].integer;
DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
} else {
DEBUG(0,("Missing job-id attribute in IPP response"));
}
}
} else {
DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),