sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-09-05 13:44:19 +03:00
Code Activity

smbd: rename open_internal_dirfsp_at() to open_internal_dirfsp()

Browse Source 
Having removed the unused dirfsp parameter this is not an AT function. Security
is provided by symlink safe fd_open().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme
2020-05-15 15:14:26 +02:00
parent ef17a408c8
commit 84cf205ff4
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source3/smbd/dir.c
View File

@@ -1369,10 +1369,10 @@ struct smb_Dir *OpenDir(TALLOC_CTX *mem_ctx,
struct smb_Dir *dir_hnd = NULL; struct smb_Dir *dir_hnd = NULL;
NTSTATUS status; NTSTATUS status;
status = open_internal_dirfsp_at(conn, status = open_internal_dirfsp(conn,
smb_dname, smb_dname,
O_RDONLY, O_RDONLY,
&fsp); &fsp);
if (!NT_STATUS_IS_OK(status)) { if (!NT_STATUS_IS_OK(status)) {
return NULL; return NULL;
} }

8
source3/smbd/files.c
View File

@@ -219,10 +219,10 @@ NTSTATUS create_internal_dirfsp_at(connection_struct *conn,
/* /*
* Open an internal fsp for an *existing* directory. * Open an internal fsp for an *existing* directory.
*/ */
NTSTATUS open_internal_dirfsp_at(connection_struct *conn, NTSTATUS open_internal_dirfsp(connection_struct *conn,
const struct smb_filename *smb_dname, const struct smb_filename *smb_dname,
int open_flags, int open_flags,
struct files_struct **_fsp) struct files_struct **_fsp)
{ {
struct files_struct *fsp = NULL; struct files_struct *fsp = NULL;
NTSTATUS status; NTSTATUS status;

8
source3/smbd/proto.h
View File

@@ -451,10 +451,10 @@ NTSTATUS create_internal_dirfsp_at(connection_struct *conn,
const struct smb_filename *smb_dname, const struct smb_filename *smb_dname,
struct files_struct **_fsp); struct files_struct **_fsp);
NTSTATUS open_internal_dirfsp_at(connection_struct *conn, NTSTATUS open_internal_dirfsp(connection_struct *conn,
const struct smb_filename *smb_dname, const struct smb_filename *smb_dname,
int open_flags, int open_flags,
struct files_struct **_fsp); struct files_struct **_fsp);
/* The following definitions come from smbd/ipc.c */ /* The following definitions come from smbd/ipc.c */