sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-27 22:50:26 +03:00
Code

talloc_stack: report lazy freeing (panic if DEVELOPER).

Browse Source 
talloc_stackframe() stacks, so if you forget to free one, the outer
one will free it.  However, it's not a good idea to rely too heavily
on this behaviour: it can lead to delays in the release of memory or
destructors.

I had an elaborate hack to make sure every talloc_stackframe() was
freed in the exact same function it was allocated, however all bugs it
caught were simply lazy freeing, so this patch just checks for that.

This doesn't check for stackframes we don't free up on exit: that would
be nice, but uncovers some uncomfortable (but probably harmless) cases.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2012-07-18 04:57:31 +09:30
parent f9b51ff33e
commit 84fb37fe37
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/util/talloc_stack.c
View File

@ -96,6 +96,17 @@ static int talloc_pop(TALLOC_CTX *frame)
(struct talloc_stackframe *)SMB_THREAD_GET_TLS(global_ts);
int i;
/* Catch lazy frame-freeing. */
if (ts->talloc_stack[ts->talloc_stacksize-1] != frame) {
DEBUG(0, ("Freed frame %s, expected %s.\n",
talloc_get_name(frame),
talloc_get_name(ts->talloc_stack
[ts->talloc_stacksize-1])));
#ifdef DEVELOPER
smb_panic("Frame not freed in order.");
#endif
}
for (i=ts->talloc_stacksize-1; i>0; i--) {
if (frame == ts->talloc_stack[i]) {
break;