sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

Remove NT_STATUS_IS_ERR_RETURN macro from the codebase.

Browse Source 
Following the current coding guidelines, it is considered bad practice to return from
within a macro and change control flow as they look like normal function calls.

Change-Id: I39b07b3a799331a5faa968629aa95b836cb78600
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Garming Sam 2014-02-14 17:46:40 +13:00 committed by Andreas Schneider
parent 4c9e0d5add
commit 856c74e013
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/wrepl_server/wrepl_in_connection.c
View File

@ -65,7 +65,9 @@ static NTSTATUS wreplsrv_process(struct wreplsrv_in_connection *wrepl_conn,
}
status = wreplsrv_in_call(call);
NT_STATUS_IS_ERR_RETURN(status);
if (NT_STATUS_IS_ERR(status)) {
return status;
}
if (!NT_STATUS_IS_OK(status)) {
/* w2k just ignores invalid packets, so we do */
DEBUG(10,("Received WINS-Replication packet was invalid, we just ignore it\n"));