From 85784854629c406f23cc46f075012696b59b392c Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 29 May 2024 16:07:53 +0200 Subject: [PATCH] python:tests/dns_base: pass tkey_trans(expected_rcode) BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett (cherry picked from commit 27d92fa808c6617353c36fdb230504e880f4925b) --- python/samba/tests/dns_base.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python/samba/tests/dns_base.py b/python/samba/tests/dns_base.py index 07e5e1b3b83..dabf3e09109 100644 --- a/python/samba/tests/dns_base.py +++ b/python/samba/tests/dns_base.py @@ -249,7 +249,8 @@ class DNSTKeyTest(DNSTest): self.newrecname = "tkeytsig.%s" % self.get_dns_domain() def tkey_trans(self, creds=None, algorithm_name="gss-tsig", - tkey_req_in_answers=False): + tkey_req_in_answers=False, + expected_rcode=dns.DNS_RCODE_OK): "Do a TKEY transaction and establish a gensec context" if creds is None: @@ -307,6 +308,9 @@ class DNSTKeyTest(DNSTest): (response, response_packet) =\ self.dns_transaction_tcp(p, self.server_ip) + if expected_rcode != dns.DNS_RCODE_OK: + self.assert_echoed_dns_error(p, response, response_packet, expected_rcode) + return self.assert_dns_rcode_equals(response, dns.DNS_RCODE_OK) tkey_record = response.answers[0].rdata