sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

s4-client: Check return codes in do_connect().

Browse Source 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
This commit is contained in:
Andreas Schneider 2012-12-13 14:11:29 +01:00 committed by Günther Deschner
parent a444bb95a2
commit 8631a9090b
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source4/client/client.c
View File

@ -3133,14 +3133,30 @@ static bool do_connect(struct smbclient_context *ctx,
if (strncmp(specified_share, "\\\\", 2) == 0 ||
strncmp(specified_share, "//", 2) == 0) {
smbcli_parse_unc(specified_share, ctx, &server, &share);
bool ok;
ok = smbcli_parse_unc(specified_share, ctx, &server, &share);
if (!ok) {
d_printf("Failed to parse UNC\n");
talloc_free(ctx);
return false;
}
} else {
share = talloc_strdup(ctx, specified_share);
server = talloc_strdup(ctx, specified_server);
if (share == NULL || server == NULL) {
d_printf("Failed to allocate memory for server and share\n");
talloc_free(ctx);
return false;
}
}
ctx->remote_cur_dir = talloc_strdup(ctx, "\\");
if (ctx->remote_cur_dir == NULL) {
talloc_free(ctx);
return false;
}
status = smbcli_full_connection(ctx, &ctx->cli, server, ports,
share, NULL,
socket_options,