sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Code

Suggestion from Volker,

Browse Source 
make ctdb_queue_length() cheaper by using a counter variable instead of counting the number of packets each time.

(This used to be ctdb commit 331c6e3afd96d8b5e191153a631efdbdabb6ea33)
This commit is contained in:
Ronnie Sahlberg 2009-10-26 12:20:52 +11:00
parent c36fa583f3
commit 8aacfa348d
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ctdb/common/ctdb_io.c
View File

@ -46,6 +46,7 @@ struct ctdb_queue {
struct ctdb_context *ctdb;
struct ctdb_partial partial; /* partial input packet */
struct ctdb_queue_pkt *out_queue;
uint32_t out_queue_length;
struct fd_event *fde;
int fd;
size_t alignment;
@ -57,12 +58,7 @@ struct ctdb_queue {
int ctdb_queue_length(struct ctdb_queue *queue)
{
int i;
struct ctdb_queue_pkt *pkt;
for(i=0, pkt=queue->out_queue;pkt;i++,pkt=pkt->next);
return i;
return queue->out_queue_length;
}
/*
@ -188,6 +184,7 @@ static void queue_io_write(struct ctdb_queue *queue)
if (pkt->length != pkt->full_length) {
/* partial packet sent - we have to drop it */
DLIST_REMOVE(queue->out_queue, pkt);
queue->out_queue_length--;
talloc_free(pkt);
}
talloc_free(queue->fde);
@ -206,6 +203,7 @@ static void queue_io_write(struct ctdb_queue *queue)
}
DLIST_REMOVE(queue->out_queue, pkt);
queue->out_queue_length--;
talloc_free(pkt);
}
@ -286,6 +284,7 @@ int ctdb_queue_send(struct ctdb_queue *queue, uint8_t *data, uint32_t length)
}
DLIST_ADD_END(queue->out_queue, pkt, struct ctdb_queue_pkt *);
queue->out_queue_length++;
if (queue->ctdb->tunable.verbose_memory_names != 0) {
struct ctdb_req_header *hdr = (struct ctdb_req_header *)pkt->data;