sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

Replaced a whole bunch of lookup_name() requests in

Browse Source 
construct_default_printer_sdb() with checks of the owner rid instead.  This
should be much faster, work on non-English systems and systems with renamed
user or group names.
This commit is contained in:
Tim Potter 0001-01-01 00:00:00 +00:00
parent 9ee43d61be
commit 8b435b0a2a
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
source/printing/nt_printing.c
View File

@ -3039,16 +3039,19 @@ static SEC_DESC_BUF *construct_default_printer_sdb(TALLOC_CTX *ctx)
if (winbind_lookup_name(lp_workgroup(), &owner_sid, &name_type)) {
sid_append_rid(&owner_sid, DOMAIN_USER_RID_ADMIN);
} else {
uint32 owner_rid;
/* Backup plan - make printer owned by admins or root. This should
emulate a lanman printer as security settings can't be
changed. */
/* Backup plan - make printer owned by admins or root.
This should emulate a lanman printer as security
settings can't be changed. */
if (!lookup_name( "Printer Administrators", &owner_sid, &name_type) &&
!lookup_name( "Administrators", &owner_sid, &name_type) &&
!lookup_name( "Administrator", &owner_sid, &name_type) &&
!lookup_name("root", &owner_sid, &name_type)) {
sid_copy(&owner_sid, &global_sid_World);
sid_peek_rid(&owner_sid, &owner_rid);
if (owner_rid != BUILTIN_ALIAS_RID_PRINT_OPS &&
owner_rid != BUILTIN_ALIAS_RID_ADMINS &&
owner_rid != DOMAIN_USER_RID_ADMIN &&
!lookup_name("root", &owner_sid, &name_type)) {
sid_copy(&owner_sid, &global_sid_World);
}
}