sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

smbd: call set_current_user_info() in change_to_user_internal() and pop_conn_ctx()

Browse Source 
change_to_user() should be the one and only function for the whole
impersonation processing. So we also need to stack the
set_current_user_info() information for become_user/unbecome_user.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Stefan Metzmacher 2018-05-25 14:22:43 +02:00
parent 91a3796481
commit 8cfe36eee9
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source3/smbd/globals.h
View File

@ -89,6 +89,7 @@ extern uint16_t fnf_handle;
struct conn_ctx {
connection_struct *conn;
uint64_t vuid;
userdom_struct user_info;
};
/* A stack of current_user connection contexts. */
extern struct conn_ctx conn_ctx_stack[MAX_SEC_CTX_DEPTH];

9
source3/smbd/uid.c
View File

@ -301,6 +301,10 @@ static bool change_to_user_internal(connection_struct *conn,
return true;
}
set_current_user_info(session_info->unix_info->sanitized_username,
session_info->unix_info->unix_name,
session_info->info->domain_name);
snum = SNUM(conn);
ok = check_user_ok(conn, vuid, session_info, snum);
@ -467,6 +471,7 @@ bool smbd_unbecome_authenticated_pipe_user(void)
static void push_conn_ctx(void)
{
struct conn_ctx *ctx_p;
extern userdom_struct current_user_info;
/* Check we don't overflow our stack */
@ -480,6 +485,7 @@ static void push_conn_ctx(void)
ctx_p->conn = current_user.conn;
ctx_p->vuid = current_user.vuid;
ctx_p->user_info = current_user_info;
DEBUG(4, ("push_conn_ctx(%llu) : conn_ctx_stack_ndx = %d\n",
(unsigned long long)ctx_p->vuid, conn_ctx_stack_ndx));
@ -501,6 +507,9 @@ static void pop_conn_ctx(void)
conn_ctx_stack_ndx--;
ctx_p = &conn_ctx_stack[conn_ctx_stack_ndx];
set_current_user_info(ctx_p->user_info.smb_name,
ctx_p->user_info.unix_name,
ctx_p->user_info.domain);
current_user.conn = ctx_p->conn;
current_user.vuid = ctx_p->vuid;