From 8d11ac4fb82dc67cbef4da27db03fa823a93be1b Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 25 Apr 2017 13:25:57 +0200 Subject: [PATCH] samba-tool: let 'samba-tool user syncpasswords' report deletions immediately We need to use the show-recycled control in addition to the notification control in order to get notifications about deletions. There's no real problem as the next modification will report the deletion. But it might be delayed a few minutes. Note that show-recycled is a superset of show-deleted, so we only need one. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12767 Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider (cherry picked from commit afa15e6128473d3e4006f7cdc3762ab4c1cba05a) Autobuild-User(v4-5-test): Karolin Seeger Autobuild-Date(v4-5-test): Tue May 9 14:34:10 CEST 2017 on sn-devel-144 --- python/samba/netcmd/user.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/samba/netcmd/user.py b/python/samba/netcmd/user.py index 2cceea8a7d0..4f1bce8ab31 100644 --- a/python/samba/netcmd/user.py +++ b/python/samba/netcmd/user.py @@ -1848,7 +1848,7 @@ samba-tool user syncpasswords --terminate \\ def sync_loop(wait): notify_attrs = ["name", "uSNCreated", "uSNChanged", "objectClass"] - notify_controls = ["notification:1"] + notify_controls = ["notification:1", "show_recycled:1"] notify_handle = self.samdb.search_iterator(expression="objectClass=*", scope=ldb.SCOPE_SUBTREE, attrs=notify_attrs,