sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

s3: VFS: vfs_snapper: Make chmod return errno = EROFS on a shadow copy path.

Browse Source 
smbd has no business modifying a shadow copy filesystem, it should be read-only.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
This commit is contained in:
Jeremy Allison 2019-08-09 10:19:31 -07:00 committed by David Disseldorp
parent 0b64e84c01
commit 8eb79cd052
1 changed files with 5 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
source3/modules/vfs_snapper.c
View File

@ -2222,45 +2222,20 @@ static int snapper_gmt_chmod(vfs_handle_struct *handle,
const struct smb_filename *smb_fname,
mode_t mode)
{
time_t timestamp;
char *stripped = NULL;
int ret, saved_errno;
char *conv = NULL;
struct smb_filename *conv_smb_fname = NULL;
time_t timestamp = 0;
if (!snapper_gmt_strip_snapshot(talloc_tos(),
handle,
smb_fname->base_name,
&timestamp,
&stripped)) {
NULL)) {
return -1;
}
if (timestamp == 0) {
TALLOC_FREE(stripped);
return SMB_VFS_NEXT_CHMOD(handle, smb_fname, mode);
}
conv = snapper_gmt_convert(talloc_tos(), handle, stripped, timestamp);
TALLOC_FREE(stripped);
if (conv == NULL) {
if (timestamp != 0) {
errno = EROFS;
return -1;
}
conv_smb_fname = synthetic_smb_fname(talloc_tos(),
conv,
NULL,
NULL,
smb_fname->flags);
if (conv_smb_fname == NULL) {
TALLOC_FREE(conv);
errno = ENOMEM;
return -1;
}
ret = SMB_VFS_NEXT_CHMOD(handle, conv_smb_fname, mode);
saved_errno = errno;
TALLOC_FREE(conv);
TALLOC_FREE(conv_smb_fname);
errno = saved_errno;
return ret;
return SMB_VFS_NEXT_CHMOD(handle, smb_fname, mode);
}
static int snapper_gmt_chown(vfs_handle_struct *handle,