sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-04 08:22:08 +03:00
Code Activity

Exit with ctdb_fatal if serverids_exist fails

Browse Source 
The only reason why this could fail is a severe ctdb communications
problem. The normal way to deal with this is ctdb_fatal. This avoids a
confusing panic in get_share_mode_lock when ctdb is shutdown while this
call happens.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
This commit is contained in:
Volker Lendecke
2013-07-04 14:22:28 +02:00
committed by Michael Adam
parent aaaff84b44
commit 8f3be3dcff
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source3/lib/ctdbd_conn.c
View File

@ -1166,7 +1166,6 @@ bool ctdb_serverids_exist(struct ctdbd_connection *conn,
NTSTATUS status; NTSTATUS status;
struct ctdb_vnn_list *vnns = NULL; struct ctdb_vnn_list *vnns = NULL;
unsigned num_vnns; unsigned num_vnns;
bool result = false;
if (!ctdb_collect_vnns(talloc_tos(), pids, num_pids, if (!ctdb_collect_vnns(talloc_tos(), pids, num_pids,
&vnns, &num_vnns)) { &vnns, &num_vnns)) {
@ -1303,10 +1302,11 @@ bool ctdb_serverids_exist(struct ctdbd_connection *conn,
num_received += 1; num_received += 1;
} }
result = true;
fail:
TALLOC_FREE(vnns); TALLOC_FREE(vnns);
return result; return true;
fail:
cluster_fatal("serverids_exist failed");
return false;
#endif /* HAVE_CTDB_CONTROL_CHECK_SRVIDS_DECL */ #endif /* HAVE_CTDB_CONTROL_CHECK_SRVIDS_DECL */
} }