sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-04 08:23:50 +03:00
Code Activity

A more-commented version of rpc_server crash fix, matching closer the

Browse Source 
previous behaviour for the 'bad bind' case.

(It is only close, not matching - Windows 2008 sends a different,
non-zero, assoc_group_id each time)

Andrew Bartlett
This commit is contained in:
Andrew Bartlett
2008-12-16 11:25:29 +11:00
parent 530758dc2a
commit 9057c2522a
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source4/rpc_server/dcerpc_server.c
View File

@@ -648,7 +648,20 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
pkt.pfc_flags = DCERPC_PFC_FLAG_FIRST | DCERPC_PFC_FLAG_LAST | extra_flags; pkt.pfc_flags = DCERPC_PFC_FLAG_FIRST | DCERPC_PFC_FLAG_LAST | extra_flags;
pkt.u.bind_ack.max_xmit_frag = 0x2000; pkt.u.bind_ack.max_xmit_frag = 0x2000;
pkt.u.bind_ack.max_recv_frag = 0x2000; pkt.u.bind_ack.max_recv_frag = 0x2000;
pkt.u.bind_ack.assoc_group_id = iface?call->context->assoc_group_id:0;
/*
make it possible for iface->bind() to specify the assoc_group_id
This helps the openchange mapiproxy plugin to work correctly.
metze
*/
if (call->context) {
pkt.u.bind_ack.assoc_group_id = call->context->assoc_group_id;
} else {
/* we better pick something - this chosen so as to send a non zero assoc_group_id (matching windows), it also matches samba3 */
pkt.u.bind_ack.assoc_group_id = SAMBA_ASSOC_GROUP;
}
if (iface) { if (iface) {
/* FIXME: Use pipe name as specified by endpoint instead of interface name */ /* FIXME: Use pipe name as specified by endpoint instead of interface name */
pkt.u.bind_ack.secondary_address = talloc_asprintf(call, "\\PIPE\\%s", iface->name); pkt.u.bind_ack.secondary_address = talloc_asprintf(call, "\\PIPE\\%s", iface->name);