sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

CVE-2016-2118: s4:librpc: use integrity by default for authenticated binds

Browse Source 
ncacn_ip_tcp:server should get the same protection as ncacn_np:server
if authentication and smb signing is used.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11616

Signed-off-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Stefan Metzmacher 2016-03-11 16:02:25 +01:00
parent d1c2ad4e16
commit 9085300e90
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source4/librpc/rpc/dcerpc_util.c
View File

@ -678,15 +678,15 @@ struct composite_context *dcerpc_pipe_auth_send(struct dcerpc_pipe *p,
/* Perform an authenticated DCE-RPC bind
*/
if (!(conn->flags & (DCERPC_SIGN|DCERPC_SEAL))) {
if (!(conn->flags & (DCERPC_CONNECT|DCERPC_SEAL))) {
/*
we are doing an authenticated connection,
but not using sign or seal. We must force
the CONNECT dcerpc auth type as a NONE auth
type doesn't allow authentication
information to be passed.
which needs to use [connect], [sign] or [seal].
If nothing is specified, we default to [sign] now.
This give roughly the same protection as
ncacn_np with smb signing.
*/
conn->flags |= DCERPC_CONNECT;
conn->flags |= DCERPC_SIGN;
}
if (conn->flags & DCERPC_AUTH_SPNEGO) {