sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

CVE-2015-5370: s4:rpc_server: remove pointless dcesrv_find_context() from dcesrv_bind()

Browse Source 
BIND is the first pdu, which means the list of contexts is always empty.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
This commit is contained in:
Stefan Metzmacher 2015-06-26 08:10:46 +02:00
parent 57afdaa79b
commit 909538c885
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source4/rpc_server/dcerpc_server.c
View File

@ -726,12 +726,6 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
} }
context_id = call->pkt.u.bind.ctx_list[0].context_id; context_id = call->pkt.u.bind.ctx_list[0].context_id;
/* you can't bind twice on one context */
if (dcesrv_find_context(call->conn, context_id) != NULL) {
return dcesrv_bind_nak(call, 0);
}
if_version = call->pkt.u.bind.ctx_list[0].abstract_syntax.if_version; if_version = call->pkt.u.bind.ctx_list[0].abstract_syntax.if_version;
uuid = call->pkt.u.bind.ctx_list[0].abstract_syntax.uuid; uuid = call->pkt.u.bind.ctx_list[0].abstract_syntax.uuid;