sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code

r14743: Fix coverity bug #227. Possible deref of null pointer

Browse Source 
in error code path.
Jeremy.
This commit is contained in:
Jeremy Allison 2006-03-27 02:51:25 +00:00 committed by Gerald (Jerry) Carter
parent bc1a605a39
commit 9117713c5e
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source/utils/net_rpc_samsync.c
View File

@ -1982,22 +1982,27 @@ static NTSTATUS fetch_database_to_ldif(struct rpc_pipe_client *pipe_hnd,
done:
/* Close and delete the ldif files */
if (add_file)
if (add_file) {
fclose(add_file);
if (strcmp(add_name, add_template) && (unlink(add_name))) {
}
if ((add_name != NULL) && strcmp(add_name, add_template) && (unlink(add_name))) {
DEBUG(1,("unlink(%s) failed, error was (%s)\n",
add_name, strerror(errno)));
}
if (mod_file)
if (mod_file) {
fclose(mod_file);
if (strcmp(mod_name, mod_template) && (unlink(mod_name))) {
}
if ((mod_name != NULL) && strcmp(mod_name, mod_template) && (unlink(mod_name))) {
DEBUG(1,("unlink(%s) failed, error was (%s)\n",
mod_name, strerror(errno)));
}
if (ldif_file && (ldif_file != stdout))
if (ldif_file && (ldif_file != stdout)) {
fclose(ldif_file);
}
/* Deallocate memory for the mapping arrays */
SAFE_FREE(groupmap);