sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

s3: Fix malformed require_membership_of_sid.

Browse Source 
Signed-off-by: Bo Yang <boyang@samba.org>
This commit is contained in:
Bo Yang 2010-02-07 14:45:42 +08:00
parent 5dbf175c75
commit 913a9f4e42
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
nsswitch/pam_winbind.c
View File

@ -1137,6 +1137,7 @@ static bool winbind_name_list_to_sid_string_list(struct pwb_context *ctx,
char *current_name = NULL;
const char *search_location;
const char *comma;
int len;
if (sid_list_buffer_size > 0) {
sid_list_buffer[0] = 0;
@ -1192,6 +1193,17 @@ static bool winbind_name_list_to_sid_string_list(struct pwb_context *ctx,
_make_remark_format(ctx, PAM_TEXT_INFO, _("Cannot convert group %s "
"to sid, please contact your administrator to see "
"if group %s is valid."), search_location, search_location);
/*
* The lookup of the last name failed..
* It results in require_member_of_sid ends with ','
* It is malformated parameter here, overwrite the last ','.
*/
len = strlen(sid_list_buffer);
if (len) {
if (sid_list_buffer[len - 1] == ',') {
sid_list_buffer[len - 1] = '\0';
}
}
}
result = true;