sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

torture/bind_dlz: return the right kind of failure

Browse Source 
torture_fail() is a macro that returns false, which evaluates to ISC_R_SUCCESS
in int context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15040

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2022-04-14 11:40:43 +12:00 committed by Andrew Bartlett
parent 5d89c90ab4
commit 937c2cd38a
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source4/torture/dns/dlz_bind9.c
View File

@ -113,7 +113,7 @@ static isc_result_t dlz_bind9_writeable_zone_hook(dns_view_t *view,
NULL
};
if (ret != LDB_SUCCESS) {
torture_fail(tctx, "Failed to connect to samdb");
torture_comment(tctx, "Failed to connect to samdb");
return ISC_R_FAILURE;
}
@ -121,7 +121,10 @@ static isc_result_t dlz_bind9_writeable_zone_hook(dns_view_t *view,
LDB_SCOPE_SUBTREE, attrs, DSDB_SEARCH_SEARCH_ALL_PARTITIONS,
"(&(objectClass=dnsZone)(name=%s))", zone_name);
if (ret != LDB_SUCCESS) {
torture_fail(tctx, talloc_asprintf(tctx, "Failed to search for %s: %s", zone_name, ldb_errstring(samdb)));
torture_comment(tctx,
"Failed to search for %s: %s",
zone_name,
ldb_errstring(samdb));
return ISC_R_FAILURE;
}
talloc_free(msg);