1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-03 12:58:35 +03:00

smbd: Fix a 100% loop at shutdown time

In the destructor of fsp->aio_requests[0] we put another request into
fsp->aio_requests[0]. Don't overwrite that with TALLOC_FREE.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jul 11 20:56:42 CEST 2013 on sn-devel-104
This commit is contained in:
Volker Lendecke 2013-07-11 16:22:26 +02:00 committed by Jeremy Allison
parent 02ff6ab5e7
commit 940395d38b

View File

@ -640,9 +640,12 @@ static NTSTATUS close_normal_file(struct smb_request *req, files_struct *fsp,
while (fsp->num_aio_requests != 0) {
/*
* The destructor of the req will remove
* itself from the fsp
* itself from the fsp.
* Don't use TALLOC_FREE here, this will overwrite
* what the destructor just wrote into
* aio_requests[0].
*/
TALLOC_FREE(fsp->aio_requests[0]);
talloc_free(fsp->aio_requests[0]);
}
}