sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-24 02:04:21 +03:00
Code

waf:replace: Do not link against libpthread if not necessary

Browse Source 
On Linux we should avoid linking everything against libpthread. Symbols
used my most application are provided by glibc and code which deals with
threads has to explicitly link against libpthread.  This avoids setting
LDFLAGS=-pthread globally.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Pair-Programmed-With: Isaac Boukris <iboukris@gmail.com>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
This commit is contained in:
Andreas Schneider 2019-09-23 16:53:12 +02:00 committed by Andreas Schneider
parent bd0cd8e132
commit 9499db075b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/replace/wscript
View File

@ -553,6 +553,11 @@ def configure(conf):
PTHREAD_CFLAGS='error'
PTHREAD_LDFLAGS='error'
if PTHREAD_LDFLAGS == 'error':
# Check if pthread_attr_init() is provided by libc first!
if conf.CHECK_FUNCS('pthread_attr_init'):
PTHREAD_CFLAGS='-D_REENTRANT'
PTHREAD_LDFLAGS=''
if PTHREAD_LDFLAGS == 'error':
if conf.CHECK_FUNCS_IN('pthread_attr_init', 'pthread'):
PTHREAD_CFLAGS='-D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS'
@ -565,10 +570,7 @@ def configure(conf):
if conf.CHECK_FUNCS_IN('pthread_attr_init', 'c_r'):
PTHREAD_CFLAGS='-D_THREAD_SAFE -pthread'
PTHREAD_LDFLAGS='-pthread'
if PTHREAD_LDFLAGS == 'error':
if conf.CHECK_FUNCS('pthread_attr_init'):
PTHREAD_CFLAGS='-D_REENTRANT'
PTHREAD_LDFLAGS='-lpthread'
# especially for HP-UX, where the CHECK_FUNC macro fails to test for
# pthread_attr_init. On pthread_mutex_lock it works there...
if PTHREAD_LDFLAGS == 'error':