sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

cmdline:burn: add a note about short option combinations

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>
(cherry picked from commit 97be45f9ea)
This commit is contained in:
Douglas Bagnall 2024-07-03 11:50:43 +12:00 committed by Jule Anger
parent 8560c854d4
commit 957654ebe9
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/cmdline/cmdline.c
View File

@ -236,6 +236,22 @@ bool samba_cmdline_burn(int argc, char *argv[])
}
if (strncmp(p, "-U", 2) == 0) {
/*
* Note: this won't catch combinations of
* short options like
* `samba-tool -NUAdministrator%...`, which is
* not possible in general outside of the
* actual parser (consider for example
* `-NHUroot%password`, which parses as
* `-N -H 'Uroot%password'`). We don't know
* here which short options might take
* arguments.
*
* This is an argument for embedding redaction
* inside the parser (e.g. by adding a flag to
* the option definitions), but we decided not
* to do that in order to share cmdline_burn().
*/
ulen = 2;
found = true;
is_user = true;