sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

winbindd: Allow the AD-DC to call getdcname

Browse Source 
This is particularly useful for RODC and eliminates a knownfail.

Change-Id: Ia5089761dcabb1620eadd530dbc9b05580cddd1f
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
This commit is contained in:
Garming Sam 2014-06-30 14:23:58 +12:00 committed by Andrew Bartlett
parent a0105b84b8
commit 95a55df021
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail
View File

@ -273,7 +273,6 @@
^samba.wbinfo_simple.\(s4member:local\).--allocate-gid
^samba.wbinfo_simple.\(plugin_s4_dc:local\).--allocate-uid
^samba.wbinfo_simple.\(plugin_s4_dc:local\).--allocate-gid
^samba.blackbox.wbinfo\(plugin_s4_dc:local\).wbinfo --getdcname against plugin_s4_dc\(plugin_s4_dc:local\)
#
# These do not work against winbindd in member mode for unknown reasons
#

22
source3/winbindd/wb_dsgetdcname.c
View File

@ -45,18 +45,28 @@ struct tevent_req *wb_dsgetdcname_send(TALLOC_CTX *mem_ctx,
return NULL;
}
if (strequal(domain_name, "BUILTIN")
|| strequal(domain_name, get_global_sam_name())) {
if (strequal(domain_name, "BUILTIN")) {
/*
* Two options here: Give back our own address, or say there's
* nobody around. Right now opting for the latter, one measure
* to prevent the loopback connects. This might change if
* needed.
* This makes no sense
*/
tevent_req_nterror(req, NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND);
return tevent_req_post(req, ev);
}
if (strequal(domain_name, get_global_sam_name())) {
int role = lp_server_role();
if ( role != ROLE_ACTIVE_DIRECTORY_DC ) {
/*
* Two options here: Give back our own address, or say there's
* nobody around. Right now opting for the latter, one measure
* to prevent the loopback connects. This might change if
* needed.
*/
tevent_req_nterror(req, NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND);
return tevent_req_post(req, ev);
}
}
if (IS_DC) {
/*
* We have to figure out the DC ourselves