From 96fe4239131f4cf7749ed25f48ba435ddee9d166 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Sat, 10 Sep 2022 20:39:19 +0200 Subject: [PATCH] s3:locking: log all share_mode_forall_entries() errors at level 0 These should never fail without notice... BUG: https://bugzilla.samba.org/show_bug.cgi?id=15125 Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison --- source3/locking/locking.c | 1 + source3/locking/share_mode_lock.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/locking/locking.c b/source3/locking/locking.c index 9a328690a70..578691c4310 100644 --- a/source3/locking/locking.c +++ b/source3/locking/locking.c @@ -716,6 +716,7 @@ NTSTATUS remove_lease_if_stale(struct share_mode_lock *lck, ok = share_mode_forall_entries(lck, find_lease_ref_fn, &state); if (!ok) { + DBG_ERR("share_mode_forall_entries failed\n"); return NT_STATUS_INTERNAL_ERROR; } diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c index 4aa11e2d097..95176331175 100644 --- a/source3/locking/share_mode_lock.c +++ b/source3/locking/share_mode_lock.c @@ -1692,7 +1692,7 @@ static int share_entry_traverse_fn(struct file_id fid, ok = share_mode_forall_entries( &lck, share_entry_traverse_walker, state); if (!ok) { - DBG_DEBUG("share_mode_forall_entries failed\n"); + DBG_ERR("share_mode_forall_entries failed\n"); return false; }