sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

netcmd: models: model __json__ method should call as_dict instead

Browse Source 
The comment about RelatedField is not really relevant so removed that part, RelatedField isn't used at this point.

The idea with RelatedField is that it fetches the object (vs DnField which just returns a Dn).

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
This commit is contained in:
Rob van der Linde 2024-02-26 13:45:54 +13:00 committed by Andrew Bartlett
parent 181764a5d6
commit 982ebebfbe
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
python/samba/netcmd/domain/models/model.py
View File

@ -111,13 +111,8 @@ class Model(metaclass=ModelMeta):
return self.dn == other.dn
def __json__(self):
"""Automatically called by custom JSONEncoder class.
When turning an object into json any fields of type RelatedField
will also end up calling this method.
"""
if self.dn is not None:
return str(self.dn)
"""Automatically called by custom JSONEncoder class."""
return self.as_dict()
@staticmethod
def get_base_dn(ldb):