sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Code

tests/krb5: Refactor out map_to_sid()

Browse Source 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-02-21 12:07:40 +13:00 committed by Andrew Bartlett
parent 033e79d40c
commit 991958c958
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
python/samba/tests/krb5/kdc_base_test.py
View File

@ -1075,6 +1075,19 @@ class KDCBaseTest(RawKerberosTest):
# Return the mapping from group IDs to principals.
return groups
def map_to_sid(self, val, mapping, domain_sid):
if isinstance(val, int):
# If it's an integer, we assume it's a RID, and prefix the domain
# SID.
return f'{domain_sid}-{val}'
if val in mapping:
# Or if we have a mapping for it, apply that.
return mapping[val].sid
# Otherwise leave it unmodified.
return val
# Return SIDs from principal placeholders based on a supplied mapping.
def map_sids(self, sids, mapping, domain_sid):
if sids is None:
@ -1088,15 +1101,8 @@ class KDCBaseTest(RawKerberosTest):
mapping,
domain_sid)))
else:
sid, sid_type, attrs = entry
if isinstance(sid, int):
# If it's an integer, we assume it's a RID, and prefix the
# domain SID.
sid = f'{domain_sid}-{sid}'
elif sid in mapping:
# Or if we have a mapping for it, apply that. Otherwise
# leave it unmodified.
sid = mapping[sid].sid
val, sid_type, attrs = entry
sid = self.map_to_sid(val, mapping, domain_sid)
# There's no point expecting the 'Claims Valid' SID to be
# present if we don't support claims. Filter it out to give the