sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

lib: Explicitly refuse to truncate unix domain socket paths

Browse Source 
This avoids creating a socket like:

.../winbindd_privileged/p

instead of

.../winbindd_privileged/pipe

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Andrew Bartlett 2019-10-18 21:11:13 +13:00 committed by Andreas Schneider
parent 8e55a85629
commit 9a02c31deb
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source3/lib/util_sock.c
View File

@ -1095,6 +1095,7 @@ int create_pipe_sock(const char *socket_dir,
int sock = -1;
mode_t old_umask;
char *path = NULL;
size_t path_len;
old_umask = umask(0);
@ -1121,7 +1122,17 @@ int create_pipe_sock(const char *socket_dir,
unlink(path);
memset(&sunaddr, 0, sizeof(sunaddr));
sunaddr.sun_family = AF_UNIX;
strlcpy(sunaddr.sun_path, path, sizeof(sunaddr.sun_path));
path_len = strlcpy(sunaddr.sun_path, path, sizeof(sunaddr.sun_path));
if (path_len > sizeof(sunaddr.sun_path)) {
DBG_ERR("Refusing to attempt to create pipe socket "
"%s. Path is longer than permitted for a "
"unix domain socket. It would truncate to "
"%s\n",
path,
sunaddr.sun_path);
goto out_close;
}
if (bind(sock, (struct sockaddr *)&sunaddr, sizeof(sunaddr)) == -1) {
DEBUG(0, ("bind failed on pipe socket %s: %s\n", path,