sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-24 02:04:21 +03:00
Code

idmap: don't generally forbid id==0 from idmap_unix_id_is_in_range()

Browse Source 
If the range allows it, then id==0 should not be forbidden.
This seems to have been taken in from idmap_ldap when the
function was originally created.

See 634cd2e0451d4388c3e3f78239495cf595368b15 .
The other backends don't seem to have had that
extra check for id == 0.

The reasoning for this change is that the range check should
apply to all cases. If the range includes the 0, then it
should be possible to get it as result. In particular,
this way, the function becomes applicable also to the
passdb backend case, e.g. in a samba4-ad-dc setup where
the Admin gets uid == 0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12155

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c21976d4b1c604699299f2c0f768c1add93b349d)
This commit is contained in:
Michael Adam 2016-08-15 23:07:33 +02:00 committed by Karolin Seeger
parent c6ac876464
commit 9a320f60cf
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source3/winbindd/idmap_util.c
View File

@ -160,11 +160,6 @@ backend:
*/ */
bool idmap_unix_id_is_in_range(uint32_t id, struct idmap_domain *dom) bool idmap_unix_id_is_in_range(uint32_t id, struct idmap_domain *dom)
{ {
if (id == 0) {
/* 0 is not an allowed unix id for id mapping */
return false;
}
if ((dom->low_id && (id < dom->low_id)) || if ((dom->low_id && (id < dom->low_id)) ||
(dom->high_id && (id > dom->high_id))) (dom->high_id && (id > dom->high_id)))
{ {