bootstrap: install codespell, shfmt and shellcheck also on debian/ubuntu

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

.gitlab-ci-main.yml

@@ -47,7 +47,7 @@ variables:
   # Set this to the contents of bootstrap/sha1sum.txt
   # which is generated by bootstrap/template.py --render
   #
-  SAMBA_CI_CONTAINER_TAG: 21a93787675107f010836bbfa5e8542c272bc4b0
+  SAMBA_CI_CONTAINER_TAG: 07a822597b5bce4af9e8e2987856b27eb20bd1b7
   #
   # We use the ubuntu2204 image as default as
   # it matches what we have on atb-devel-224

bootstrap/config.py

@@ -42,6 +42,7 @@ COMMON = [
     'ccache',
     'curl',
     'chrpath',
+    'codespell',
     'flex',
     'gcc',
     'gdb',
@@ -58,6 +59,7 @@ COMMON = [
     'rng-tools',
     'rsync',
     'sed',
+    'shfmt',
     'sudo',  # docker images has no sudo by default
     'tar',
     'tree',
@@ -134,10 +136,8 @@ PKGS = [
     ('', 'rpcsvc-proto-devel'), # for <rpcsvc/rquota.h> header
     ('mawk', 'gawk'),
     ('', 'mold'),
-    ('', 'ShellCheck'),
-    ('', 'shfmt'),
+    ('shellcheck', 'ShellCheck'),
     ('', 'crypto-policies-scripts'),
-    ('', 'codespell'),
 
     ('python3', 'python3'),
     ('python3-cryptography', 'python3-cryptography'), # for krb5 tests
@@ -420,6 +420,7 @@ DEB_DISTS = {
         'vagrant_box': 'debian/bullseye64',
         'replace': {
             'language-pack-en': '',   # included in locales
+            'shfmt': '',
         }
     },
     'debian11-32bit': {
@@ -427,6 +428,7 @@ DEB_DISTS = {
         'vagrant_box': 'debian/bullseye32',
         'replace': {
             'language-pack-en': '',   # included in locales
+            'shfmt': '',
         }
     },
     'debian12': {
@@ -450,6 +452,7 @@ DEB_DISTS = {
         'vagrant_box': 'ubuntu/bionic64',
         'replace': {
             'liburing-dev': '',   # not available
+            'shfmt': '',
         }
     },
     'ubuntu1804-32bit': {
@@ -457,6 +460,7 @@ DEB_DISTS = {
         'vagrant_box': 'ubuntu/bionic32',
         'replace': {
             'liburing-dev': '',   # not available
+            'shfmt': '',
         }
     },
     'ubuntu2004': {
@@ -464,6 +468,7 @@ DEB_DISTS = {
         'vagrant_box': 'ubuntu/focal64',
         'replace': {
             'liburing-dev': '',   # not available
+            'shfmt': '',
         }
     },
     'ubuntu2204': {

bootstrap/generated-dists/debian11-32bit/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -100,6 +101,7 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/debian11-32bit/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -89,6 +90,7 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
   - sudo
   - tar
   - tree

bootstrap/generated-dists/debian11/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -100,6 +101,7 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/debian11/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -89,6 +90,7 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
   - sudo
   - tar
   - tree

bootstrap/generated-dists/debian12-32bit/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -99,6 +100,8 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
+    shfmt \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/debian12-32bit/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -88,6 +89,8 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
+  - shfmt
   - sudo
   - tar
   - tree

bootstrap/generated-dists/debian12/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -99,6 +100,8 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
+    shfmt \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/debian12/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -88,6 +89,8 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
+  - shfmt
   - sudo
   - tar
   - tree

bootstrap/generated-dists/ubuntu1804-32bit/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -100,6 +101,7 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/ubuntu1804-32bit/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -89,6 +90,7 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
   - sudo
   - tar
   - tree

bootstrap/generated-dists/ubuntu1804/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -100,6 +101,7 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/ubuntu1804/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -89,6 +90,7 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
   - sudo
   - tar
   - tree

bootstrap/generated-dists/ubuntu2004/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -100,6 +101,7 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/ubuntu2004/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -89,6 +90,7 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
   - sudo
   - tar
   - tree

bootstrap/generated-dists/ubuntu2204/bootstrap.sh

@@ -21,6 +21,7 @@ apt-get -y install \
     build-essential \
     ccache \
     chrpath \
+    codespell \
     curl \
     debhelper \
     dnsutils \
@@ -100,6 +101,8 @@ apt-get -y install \
     rng-tools \
     rsync \
     sed \
+    shellcheck \
+    shfmt \
     sudo \
     tar \
     tree \

bootstrap/generated-dists/ubuntu2204/packages.yml

@@ -10,6 +10,7 @@ packages:
   - build-essential
   - ccache
   - chrpath
+  - codespell
   - curl
   - debhelper
   - dnsutils
@@ -89,6 +90,8 @@ packages:
   - rng-tools
   - rsync
   - sed
+  - shellcheck
+  - shfmt
   - sudo
   - tar
   - tree

bootstrap/sha1sum.txt

@@ -1 +1 @@
-21a93787675107f010836bbfa5e8542c272bc4b0
+07a822597b5bce4af9e8e2987856b27eb20bd1b7