sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-12 21:58:10 +03:00
Code

memory problems associated with when lsalookupsids returns

Browse Source 
NT_STATUS_NONE_MAPPED.
This commit is contained in:
Luke Leighton -
parent d3dd8cdc12
commit 9a43a25511
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
source/rpc_client/cli_lsarpc.c
View File

@ -361,8 +361,23 @@ BOOL lsa_lookup_sids(struct cli_state *cli, uint16 fnum,
LSA_Q_LOOKUP_SIDS q_l;
BOOL valid_response = False;
ZERO_STRUCT(q_l);
if (hnd == NULL || num_sids == 0 || sids == NULL) return False;
if (num_names != NULL)
{
*num_names = 0;
}
if (types != NULL)
{
*types = NULL;
}
if (names != NULL)
{
*names = NULL;
}
prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
prs_init(&rbuf, 0 , 4, SAFETY_MARGIN, True );
@ -390,7 +405,9 @@ BOOL lsa_lookup_sids(struct cli_state *cli, uint16 fnum,
lsa_io_r_lookup_sids("", &r_l, &rbuf, 0);
p = rbuf.offset != 0;
if (p && r_l.status != 0 && r_l.status != 0x107)
if (p && r_l.status != 0 &&
r_l.status != 0x107 &&
r_l.status != 0xC0000000 | NT_STATUS_NONE_MAPPED)
{
/* report error code */
DEBUG(1,("LSA_LOOKUP_SIDS: %s\n", get_nt_error_msg(r_l.status)));
@ -423,12 +440,12 @@ BOOL lsa_lookup_sids(struct cli_state *cli, uint16 fnum,
}
}
if (types != NULL && valid_response && t_names.num_entries != 0)
if (types != NULL && valid_response && (*num_names) != 0)
{
(*types) = (uint8*)malloc((*num_names) * sizeof(uint8));
}
if (names != NULL && valid_response && t_names.num_entries != 0)
if (names != NULL && valid_response && (*num_names) != 0)
{
(*names) = (char**)malloc((*num_names) * sizeof(char*));
}