mirror of
https://github.com/samba-team/samba.git
synced 2025-01-06 13:18:07 +03:00
s3: Fixup test for CVE-2017-2619 regression with "follow symlinks = no"
Use correct bash operators (not string operators).
Add missing "return".
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12721
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 037297a1c5
)
This commit is contained in:
parent
161a078f55
commit
9a5be8b68b
@ -1098,7 +1098,7 @@ EOF
|
||||
ret=$?
|
||||
rm -f $tmpfile
|
||||
|
||||
if [ $ret != 0 ] ; then
|
||||
if [ $ret -ne 0 ] ; then
|
||||
echo "$out"
|
||||
echo "failed accessing nosymlinks with error $ret"
|
||||
false
|
||||
@ -1107,10 +1107,11 @@ EOF
|
||||
|
||||
echo "$out" | grep 'NT_STATUS_ACCESS_DENIED'
|
||||
ret=$?
|
||||
if [ $ret != 0 ] ; then
|
||||
if [ $ret -ne 0 ] ; then
|
||||
echo "$out"
|
||||
echo "failed - should get NT_STATUS_ACCESS_DENIED getting \\nosymlinks\\source"
|
||||
false
|
||||
return
|
||||
fi
|
||||
|
||||
# But we should be able to create and delete directories.
|
||||
@ -1125,7 +1126,7 @@ EOF
|
||||
ret=$?
|
||||
rm -f $tmpfile
|
||||
|
||||
if [ $ret != 0 ] ; then
|
||||
if [ $ret -ne 0 ] ; then
|
||||
echo "$out"
|
||||
echo "failed accessing nosymlinks with error $ret"
|
||||
false
|
||||
@ -1134,7 +1135,7 @@ EOF
|
||||
|
||||
echo "$out" | grep 'NT_STATUS'
|
||||
ret=$?
|
||||
if [ $ret == 0 ] ; then
|
||||
if [ $ret -eq 0 ] ; then
|
||||
echo "$out"
|
||||
echo "failed - NT_STATUS_XXXX doing mkdir a; mkdir a\\b on \\nosymlinks"
|
||||
false
|
||||
|
Loading…
Reference in New Issue
Block a user