sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

nsswitch: Fix memory leak in test_wbc_pingdc2()

Browse Source 
Found by cppcheck.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
This commit is contained in:
Andreas Schneider 2016-06-22 08:04:53 +02:00 committed by Andreas Schneider
parent 4961362106
commit 9b732c2448
1 changed files with 39 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
nsswitch/libwbclient/tests/wbclient.c
View File

@ -115,35 +115,55 @@ fail:
static bool test_wbc_pingdc2(struct torture_context *tctx)
{
struct wbcInterfaceDetails *details;
struct wbcInterfaceDetails *details = NULL;
char *name = NULL;
wbcErr ret = false;
torture_assert_wbc_equal(tctx, wbcPingDc2("random_string", NULL, &name),
WBC_ERR_DOMAIN_NOT_FOUND, "%s",
"wbcPingDc2 failed");
torture_assert_wbc_ok(tctx, wbcPingDc2(NULL, NULL, &name), "%s",
"wbcPingDc2 failed");
torture_assert_wbc_equal_goto_fail(tctx,
wbcPingDc2("random_string", NULL, &name),
WBC_ERR_DOMAIN_NOT_FOUND,
"%s",
"wbcPingDc2 failed");
torture_assert_wbc_ok_goto_fail(tctx,
wbcPingDc2(NULL, NULL, &name),
"%s",
"wbcPingDc2 failed");
wbcFreeMemory(name);
name = NULL;
torture_assert_wbc_ok(tctx, wbcInterfaceDetails(&details),
"%s", "wbcInterfaceDetails failed");
torture_assert(tctx, details,
"wbcInterfaceDetails returned NULL pointer");
torture_assert(tctx, details->netbios_domain,
"wbcInterfaceDetails returned NULL netbios_domain");
torture_assert_wbc_ok_goto_fail(tctx,
wbcInterfaceDetails(&details),
"%s",
"wbcInterfaceDetails failed");
torture_assert_goto(tctx,
details,
ret,
fail,
"wbcInterfaceDetails returned NULL pointer");
torture_assert_goto(tctx,
details->netbios_domain,
ret,
fail,
"wbcInterfaceDetails returned NULL netbios_domain");
torture_assert_wbc_ok(tctx, wbcPingDc2(details->netbios_domain, NULL, &name),
"wbcPingDc2(%s) failed", details->netbios_domain);
torture_assert_wbc_ok_goto_fail(tctx,
wbcPingDc2(details->netbios_domain, NULL, &name),
"wbcPingDc2(%s) failed",
details->netbios_domain);
wbcFreeMemory(name);
name = NULL;
torture_assert_wbc_ok(tctx, wbcPingDc2("BUILTIN", NULL, &name),
"%s", "wbcPingDc2(BUILTIN) failed");
torture_assert_wbc_ok_goto_fail(tctx,
wbcPingDc2("BUILTIN", NULL, &name),
"%s",
"wbcPingDc2(BUILTIN) failed");
ret = true;
fail:
wbcFreeMemory(name);
wbcFreeMemory(details);
return true;
return ret;
}
static bool test_wbc_library_details(struct torture_context *tctx)