From 9c68f99654c851491a4fb499a358af6c400a8dea Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 11 Jul 2017 13:50:09 +0200 Subject: [PATCH] spoolss: Fix CID 1414784 Uninitialized scalar variable "struct tm" can contain more members than we explicitly initialize. Initialize them all. Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source3/rpc_client/init_spoolss.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/source3/rpc_client/init_spoolss.c b/source3/rpc_client/init_spoolss.c index a806fc6ce09..e5f70c0b045 100644 --- a/source3/rpc_client/init_spoolss.c +++ b/source3/rpc_client/init_spoolss.c @@ -48,15 +48,15 @@ bool init_systemtime(struct spoolss_Time *r, time_t spoolss_Time_to_time_t(const struct spoolss_Time *r) { - struct tm unixtime; - - unixtime.tm_year = r->year - 1900; - unixtime.tm_mon = r->month - 1; - unixtime.tm_wday = r->day_of_week; - unixtime.tm_mday = r->day; - unixtime.tm_hour = r->hour; - unixtime.tm_min = r->minute; - unixtime.tm_sec = r->second; + struct tm unixtime = { + .tm_year = r->year - 1900, + .tm_mon = r->month - 1, + .tm_wday = r->day_of_week, + .tm_mday = r->day, + .tm_hour = r->hour, + .tm_min = r->minute, + .tm_sec = r->second, + }; return mktime(&unixtime); }