sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

tevent_signal: Fix a valgrind error

Browse Source 
This fixes an uninitialized read introduced by my fix for the tevent_signal
destructors. From looking at the code you might believe that this kicks in only
when talloc failed. But with -O3 I do see it in normal operations.

Sorry for that.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 15 17:58:37 CET 2012 on sn-devel-104
This commit is contained in:
Volker Lendecke 2012-02-15 16:17:34 +01:00
parent 740d4d7550
commit 9e25361203
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/tevent/tevent_signal.c
View File

@ -346,6 +346,8 @@ int tevent_common_check_signal(struct tevent_context *ev)
struct tevent_signal *se = sl->se; struct tevent_signal *se = sl->se;
struct tevent_se_exists *exists; struct tevent_se_exists *exists;
next = sl->next;
/* /*
* We have to be careful to not touch "se" * We have to be careful to not touch "se"
* after it was deleted in its handler. Thus * after it was deleted in its handler. Thus
@ -361,7 +363,6 @@ int tevent_common_check_signal(struct tevent_context *ev)
talloc_set_destructor( talloc_set_destructor(
exists, tevent_se_exists_destructor); exists, tevent_se_exists_destructor);
next = sl->next;
#ifdef SA_SIGINFO #ifdef SA_SIGINFO
if (se->sa_flags & SA_SIGINFO) { if (se->sa_flags & SA_SIGINFO) {
uint32_t j; uint32_t j;