From 9e706ee5737bffd6f0a699ce68a75bbd0f7fd7dd Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Sun, 21 Apr 2019 08:38:23 +0200 Subject: [PATCH] unittest: workaround dependency problem in test_lib_util_modules waf somehow screws the dependencies and the module ends up with a bunch of missing RPC related symbols once an RPC service has special dependencies like the mdssvc RPC service. $ bin/test_lib_util_modules test: test_samba_module_probe success: test_samba_module_probe test: test_samba_module_probe_dummy Error loading module '/home/samba/src/bin/modules/rpc/test_dummy_module.so': /home/samba/src/bin/modules/rpc/test_dummy_module.so: undefined symbol: rpc_service_mode failure: test_samba_module_probe_dummy [ NT_STATUS_IS_OK(status) ../../testsuite/unittests/test_lib_util_modules.c:39: error: Failure! ] test: test_samba_module_probe_slash success: test_samba_module_probe_slash This is currently not noticed as mdssvc is not enabled in selftest, but that is going to change with a subsequent commit. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- testsuite/unittests/wscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/unittests/wscript b/testsuite/unittests/wscript index 561cb4bebad..40fcb01ad57 100644 --- a/testsuite/unittests/wscript +++ b/testsuite/unittests/wscript @@ -30,7 +30,7 @@ def build(bld): bld.SAMBA_MODULE('rpc_test_dummy_module', source='rpc_test_dummy_module.c', - deps='ndr', + deps='ndr smbd_base', subsystem='rpc', allow_undefined_symbols=True, init_function='',