sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

Fix more "ignore return value" warnings from gcc 4.3.

Browse Source 
Jeremy
This commit is contained in:
Jeremy Allison 2008-12-30 18:24:39 -08:00
parent a66c034c8e
commit 9eab2bfaf1
4 changed files with 31 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
source3/libads/kerberos_verify.c
View File

@ -69,13 +69,27 @@ static bool ads_keytab_verify_ticket(krb5_context context,
my_fqdn[0] = '\0';
name_to_fqdn(my_fqdn, global_myname());
asprintf(&valid_princ_formats[0], "%s$@%s", my_name, lp_realm());
asprintf(&valid_princ_formats[1], "host/%s@%s", my_name, lp_realm());
asprintf(&valid_princ_formats[2], "host/%s@%s", my_fqdn, lp_realm());
asprintf(&valid_princ_formats[3], "host/%s.%s@%s", my_name, lp_realm(), lp_realm());
asprintf(&valid_princ_formats[4], "cifs/%s@%s", my_name, lp_realm());
asprintf(&valid_princ_formats[5], "cifs/%s@%s", my_fqdn, lp_realm());
asprintf(&valid_princ_formats[6], "cifs/%s.%s@%s", my_name, lp_realm(), lp_realm());
if (asprintf(&valid_princ_formats[0], "%s$@%s", my_name, lp_realm()) == -1) {
goto out;
}
if (asprintf(&valid_princ_formats[1], "host/%s@%s", my_name, lp_realm()) == -1) {
goto out;
}
if (asprintf(&valid_princ_formats[2], "host/%s@%s", my_fqdn, lp_realm()) == -1) {
goto out;
}
if (asprintf(&valid_princ_formats[3], "host/%s.%s@%s", my_name, lp_realm(), lp_realm()) == -1) {
goto out;
}
if (asprintf(&valid_princ_formats[4], "cifs/%s@%s", my_name, lp_realm()) == -1) {
goto out;
}
if (asprintf(&valid_princ_formats[5], "cifs/%s@%s", my_fqdn, lp_realm()) == -1) {
goto out;
}
if (asprintf(&valid_princ_formats[6], "cifs/%s.%s@%s", my_name, lp_realm(), lp_realm()) == -1) {
goto out;
}
ZERO_STRUCT(kt_entry);
ZERO_STRUCT(kt_cursor);
@ -375,8 +389,7 @@ NTSTATUS ads_verify_ticket(TALLOC_CTX *mem_ctx,
krb5_auth_con_setflags( context, auth_context, flags );
}
asprintf(&host_princ_s, "%s$", global_myname());
if (!host_princ_s) {
if (asprintf(&host_princ_s, "%s$", global_myname()) == -1) {
goto out;
}

4
source3/web/cgi.c
View File

@ -498,7 +498,9 @@ static void cgi_download(char *file)
printf("Content-Length: %d\r\n\r\n", (int)st.st_size);
while ((l=read(fd,buf,sizeof(buf)))>0) {
fwrite(buf, 1, l, stdout);
if (fwrite(buf, 1, l, stdout) != l) {
break;
}
}
close(fd);
exit(0);

3
source3/web/neg_lang.c
View File

@ -32,8 +32,7 @@ int web_open(const char *fname, int flags, mode_t mode)
char *lang = lang_tdb_current();
int fd;
if (lang) {
asprintf(&p, "lang/%s/%s", lang, fname);
if (p) {
if (asprintf(&p, "lang/%s/%s", lang, fname) != -1) {
fd = sys_open(p, flags, mode);
free(p);
if (fd != -1) {

8
source3/web/swat.c
View File

@ -156,7 +156,9 @@ static int include_html(const char *fname)
}
while ((ret = read(fd, buf, sizeof(buf))) > 0) {
write(1, buf, ret);
if (write(1, buf, ret) == -1) {
break;
}
}
close(fd);
@ -1253,8 +1255,8 @@ static void printers_page(void)
printf("<H2>%s</H2>\n", _("Printer Parameters"));
printf("<H3>%s</H3>\n", _("Important Note:"));
printf(_("Printer names marked with [*] in the Choose Printer drop-down box "));
printf(_("are autoloaded printers from "));
printf("%s",_("Printer names marked with [*] in the Choose Printer drop-down box "));
printf("%s",_("are autoloaded printers from "));
printf("<A HREF=\"/swat/help/smb.conf.5.html#printcapname\" target=\"docs\">%s</A>\n", _("Printcap Name"));
printf("%s\n", _("Attempting to delete these printers from SWAT will have no effect."));