sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-24 13:57:43 +03:00
Code

s3: VFS: vfs_glusterfs. Protect vfs_gluster_fsync_done() from accessing a freed req pointer.

Browse Source 
If the fsp is forced closed by a SHUTDOWN_CLOSE whilst the
request is in flight (share forced closed by smbcontrol),
then we set state->req = NULL in the state destructor.

The existing state destructor prevents the state memory
from being freed, so when the thread completes and calls
vfs_gluster_fsync_done(), just throw away the result if
state->req == NULL.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Jeremy Allison 2020-02-28 16:01:11 -08:00
parent cdde55a69d
commit 9ecbda263f
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source3/modules/vfs_glusterfs.c
View File

@ -1197,6 +1197,15 @@ static void vfs_gluster_fsync_do(void *private_data)
static int vfs_gluster_fsync_state_destructor(struct vfs_gluster_fsync_state *state)
{
/*
* This destructor only gets called if the request is still
* in flight, which is why we deny it by returning -1. We
* also set the req pointer to NULL so the _done function
* can detect the caller doesn't want the result anymore.
*
* Forcing the fsp closed by a SHUTDOWN_CLOSE can cause this.
*/
state->req = NULL;
return -1;
}
@ -1211,6 +1220,17 @@ static void vfs_gluster_fsync_done(struct tevent_req *subreq)
TALLOC_FREE(subreq);
SMBPROFILE_BYTES_ASYNC_END(state->profile_bytes);
talloc_set_destructor(state, NULL);
if (req == NULL) {
/*
* We were shutdown closed in flight. No one
* wants the result, and state has been reparented
* to the NULL context, so just free it so we
* don't leak memory.
*/
DBG_NOTICE("gluster fsync request abandoned in flight\n");
TALLOC_FREE(state);
return;
}
if (ret != 0) {
if (ret != EAGAIN) {
tevent_req_error(req, ret);