1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00

s4:samba-tool/testparm: add a warning when acting as an AD-DC and not using UTF-8

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>

Autobuild-User(master): Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date(master): Mon Feb 10 02:26:28 CET 2014 on sn-devel-104
This commit is contained in:
Garming Sam 2014-01-03 11:14:13 +13:00 committed by Kamen Mazdrashki
parent a3979677a8
commit 9f2e6f532d

View File

@ -156,6 +156,14 @@ class cmd_testparm(Command):
"membership.")
valid = False
role = lp.get("server role")
charset = lp.get("unix charset").upper()
if role in ["active directory domain controller", "domain controller", "dc"] and charset not in ["UTF-8", "UTF8"]:
logger.warning(
"When acting as Active Directory domain controller, "
"unix charset is expected to be UTF-8.")
return valid
def allow_access(self, deny_list, allow_list, cname, caddr):