sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

ctdb-common: Protocol argument must be in host order for socket() call

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11705

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Amitay Isaacs 2016-01-29 00:05:26 +11:00 committed by Volker Lendecke
parent 6831ba35b9
commit 9f8395cb7d
6 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ctdb/common/system_aix.c
View File

@ -50,7 +50,7 @@ int ctdb_sys_open_sending_socket(void)
int s, ret; int s, ret;
uint32_t one = 1; uint32_t one = 1;
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(" failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(" failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));
@ -127,7 +127,7 @@ int ctdb_sys_send_tcp(const ctdb_sock_addr *dest,
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(" failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(" failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));

2
ctdb/common/system_common.c
View File

@ -90,7 +90,7 @@ char *ctdb_sys_find_ifname(ctdb_sock_addr *addr)
struct ifconf ifc; struct ifconf ifc;
char *ptr; char *ptr;
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));

2
ctdb/common/system_freebsd.c
View File

@ -164,7 +164,7 @@ int ctdb_sys_send_tcp(const ctdb_sock_addr *dest,
ip4pkt.tcp.th_sum = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip); ip4pkt.tcp.th_sum = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip);
/* open a raw socket to send this segment from */ /* open a raw socket to send this segment from */
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));

2
ctdb/common/system_gnu.c
View File

@ -162,7 +162,7 @@ int ctdb_sys_send_tcp(const ctdb_sock_addr *dest,
ip4pkt.tcp.check = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip); ip4pkt.tcp.check = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip);
/* open a raw socket to send this segment from */ /* open a raw socket to send this segment from */
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));

2
ctdb/common/system_kfreebsd.c
View File

@ -162,7 +162,7 @@ int ctdb_sys_send_tcp(const ctdb_sock_addr *dest,
ip4pkt.tcp.check = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip); ip4pkt.tcp.check = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip);
/* open a raw socket to send this segment from */ /* open a raw socket to send this segment from */
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));

8
ctdb/common/system_linux.c
View File

@ -100,7 +100,7 @@ int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
switch (addr->ip.sin_family) { switch (addr->ip.sin_family) {
case AF_INET: case AF_INET:
s = socket(PF_PACKET, SOCK_RAW, htons(ETHERTYPE_ARP)); s = socket(PF_PACKET, SOCK_RAW, ETHERTYPE_ARP);
if (s == -1){ if (s == -1){
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket\n")); DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket\n"));
return -1; return -1;
@ -194,7 +194,7 @@ int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
close(s); close(s);
break; break;
case AF_INET6: case AF_INET6:
s = socket(PF_PACKET, SOCK_RAW, htons(ETHERTYPE_ARP)); s = socket(PF_PACKET, SOCK_RAW, ETHERTYPE_ARP);
if (s == -1){ if (s == -1){
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket\n")); DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket\n"));
return -1; return -1;
@ -370,7 +370,7 @@ int ctdb_sys_send_tcp(const ctdb_sock_addr *dest,
ip4pkt.tcp.check = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip); ip4pkt.tcp.check = tcp_checksum((uint16_t *)&ip4pkt.tcp, sizeof(ip4pkt.tcp), &ip4pkt.ip);
/* open a raw socket to send this segment from */ /* open a raw socket to send this segment from */
s = socket(AF_INET, SOCK_RAW, htons(IPPROTO_RAW)); s = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n", DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket (%s)\n",
strerror(errno))); strerror(errno)));
@ -460,7 +460,7 @@ int ctdb_sys_open_capture_socket(const char *iface, void **private_data)
int s; int s;
/* Open a socket to capture all traffic */ /* Open a socket to capture all traffic */
s = socket(AF_PACKET, SOCK_RAW, htons(ETH_P_ALL)); s = socket(AF_PACKET, SOCK_RAW, ETH_P_ALL);
if (s == -1) { if (s == -1) {
DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket\n")); DEBUG(DEBUG_CRIT,(__location__ " failed to open raw socket\n"));
return -1; return -1;