From 9fab393a9c3047c2c35e8c56b1d6a5e0af541cf2 Mon Sep 17 00:00:00 2001
From: Noel Power <noel.power@suse.com>
Date: Fri, 13 Dec 2019 12:22:05 +0000
Subject: [PATCH] s3/selftest: Move raw.samba3checkfsp, raw.samba3hide &
raw.samba3closeerr
Tests samba3.raw.samba3checkfsp, samba3.raw.samba3hide &
samba3.raw.samba3closeerr fail in test environments that don't support
SMB1 so move to nt4_dc_smb1. Additionally samba3.raw.samba3closeer was
a known fail in nt4_dc so this also needs to be adjusted for the new
env.
Remove the remaining entries from skip_smb1_fail
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
---
selftest/knownfail | 2 +-
selftest/skip_smb1_fails | 2 --
source3/selftest/tests.py | 2 +-
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/selftest/knownfail b/selftest/knownfail
index 051b7d6317d..63739e7c271 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -25,7 +25,7 @@
^samba3.smb2.rename.*.no_share_delete_no_delete_access
^samba3.blackbox.smbclient_machine_auth.plain.*nt4_dc:local # the NT4 DC does not currently set up a self-join
^samba3.raw.samba3hide.samba3hide\(ad_dc\) # This test fails against the ad_dc environment.
-^samba3.raw.samba3closeerr.samba3closeerr\(nt4_dc\) # This test fails against an smbd environment with NT ACLs enabled
+^samba3.raw.samba3closeerr.samba3closeerr\(nt4_dc_smb1\) # This test fails against an smbd environment with NT ACLs enabled
^samba3.raw.acls nfs4acl_xattr-simple-40.INHERITFLAGS\(nt4_dc_smb1\) # This (and the follow nfs4acl_xattr tests fail because our NFSv4 backend isn't a complete mapping yet.
^samba3.raw.acls nfs4acl_xattr-simple-40.create_owner_file\(nt4_dc_smb1\)
^samba3.raw.acls nfs4acl_xattr-simple-40.create_owner_dir\(nt4_dc_smb1\)
diff --git a/selftest/skip_smb1_fails b/selftest/skip_smb1_fails
index b0086975242..22d5fd081f3 100644
--- a/selftest/skip_smb1_fails
+++ b/selftest/skip_smb1_fails
@@ -19,10 +19,8 @@
^samba3.blackbox.smbclient_s3.NT1.plain.member_creds\(nt4_member\)
^samba3.blackbox.smbclient_s3.NT1.sign.member_creds\(ad_member\)
^samba3.blackbox.smbclient_s3.NT1.sign.member_creds\(nt4_member\)
-^samba3.raw.samba3checkfsp\(nt4_dc\)
^samba3.raw.samba3checkfsp\(simpleserver\)
^samba3.raw.samba3closeerr\(simpleserver\)
-^samba3.raw.samba3hide\(nt4_dc\)
^samba3.raw.samba3hide\(simpleserver\)
^samba3.raw.samba3posixtimedlock\(ad_dc\)
^samba3.raw.samba3posixtimedlock\(nt4_dc\)
diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py
index e7771759098..76f1442c4cc 100755
--- a/source3/selftest/tests.py
+++ b/source3/selftest/tests.py
@@ -597,7 +597,7 @@ for t in tests:
plansmbtorture4testsuite(t, "nt4_dc_smb1", '//$SERVER_IP/tmpcase -U$USERNAME%$PASSWORD')
plansmbtorture4testsuite(t, "ad_dc_smb1", '//$SERVER_IP/tmpcase -U$USERNAME%$PASSWORD')
elif t == "raw.samba3hide" or t == "raw.samba3checkfsp" or t == "raw.samba3closeerr":
- plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD')
+ plansmbtorture4testsuite(t, "nt4_dc_smb1", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD')
plansmbtorture4testsuite(t, "simpleserver", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD')
plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$USERNAME%$PASSWORD')
elif t == "raw.session":