sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

s3: Don't invalidate cache for uninitialized domains.

Browse Source 
Signed-off-by: Bo Yang <boyang@samba.org>
This commit is contained in:
Bo Yang 2010-02-09 16:35:40 +08:00
parent 8c8bb51de1
commit 9fed9011ff
3 changed files with 52 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
source3/winbindd/winbindd.c
View File

@ -141,6 +141,29 @@ static void flush_caches(void)
}
}
static void flush_caches_noinit(void)
{
/*
* We need to invalidate cached user list entries on a SIGHUP
* otherwise cached access denied errors due to restrict anonymous
* hang around until the sequence number changes.
* NB
* Skip uninitialized domains when flush cache.
* If domain is not initialized, it means it is never
* used or never become online. look, wcache_invalidate_cache()
* -> get_cache() -> init_dc_connection(). It causes a lot of traffic
* for unused domains and large traffic for primay domain's DC if there
* are many domains..
*/
if (!wcache_invalidate_cache_noinit()) {
DEBUG(0, ("invalidating the cache failed; revalidate the cache\n"));
if (!winbindd_cache_validate_and_initialize()) {
exit(1);
}
}
}
/* Handle the signal by unlinking socket and exiting */
static void terminate(bool is_parent)
@ -254,7 +277,7 @@ static void winbindd_sig_hup_handler(struct tevent_context *ev,
const char *file = (const char *)private_data;
DEBUG(1,("Reloading services after SIGHUP\n"));
flush_caches();
flush_caches_noinit();
reload_services_file(file);
}

27
source3/winbindd/winbindd_cache.c
View File

@ -3023,6 +3023,33 @@ bool wcache_invalidate_cache(void)
return true;
}
bool wcache_invalidate_cache_noinit(void)
{
struct winbindd_domain *domain;
for (domain = domain_list(); domain; domain = domain->next) {
struct winbind_cache *cache;
/* Skip uninitialized domains. */
if (!domain->initialized && !domain->internal) {
continue;
}
cache = get_cache(domain);
DEBUG(10, ("wcache_invalidate_cache: invalidating cache "
"entries for %s\n", domain->name));
if (cache) {
if (cache->tdb) {
tdb_traverse(cache->tdb, traverse_fn, NULL);
} else {
return false;
}
}
}
return true;
}
bool init_wcache(void)
{
if (wcache == NULL) {

1
source3/winbindd/winbindd_proto.h
View File

@ -104,6 +104,7 @@ NTSTATUS wcache_save_creds(struct winbindd_domain *domain,
void wcache_invalidate_samlogon(struct winbindd_domain *domain,
struct netr_SamInfo3 *info3);
bool wcache_invalidate_cache(void);
bool wcache_invalidate_cache_noinit(void);
bool init_wcache(void);
bool initialize_winbindd_cache(void);
void close_winbindd_cache(void);