sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4:dsdb:strcasecmp_with_ldb_val() avoids overflow

Browse Source 
In the unlikely event that strlen(str) > INT_MAX, the result could
have overflowed.

This is not a sort transitivity issue, as this is not a symmetric sort
comparison, but it would affect binary search reliability.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2024-05-13 11:08:35 +12:00 committed by Andrew Bartlett
parent b6974030e6
commit a00c0ebd09
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/dsdb/schema/schema_query.c
View File

@ -52,7 +52,9 @@ static int strcasecmp_with_ldb_val(const struct ldb_val *target, const char *str
} }
return 1; return 1;
} }
return (target->length - len); if (target->length < len) {
return -1;
}
} }
return ret; return ret;
} }