sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code

s3: Fix Coverity ID 1012, CHECKED_RETURN

Browse Source 
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
This commit is contained in:
Volker Lendecke 2011-03-16 18:50:02 +01:00
parent 9c9ed33cb7
commit a282455978
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/rpc_server/lsa/srv_lsa_nt.c
View File

@ -184,7 +184,7 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx,
int dom_idx;
const char *full_name;
const char *domain;
enum lsa_SidType type = SID_NAME_UNKNOWN;
enum lsa_SidType type;
/* Split name into domain and user component */
@ -199,11 +199,10 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx,
DEBUG(5, ("lookup_lsa_rids: looking up name %s\n", full_name));
/* We can ignore the result of lookup_name, it will not touch
"type" if it's not successful */
lookup_name(mem_ctx, full_name, flags, &domain, NULL,
&sid, &type);
if (!lookup_name(mem_ctx, full_name, flags, &domain, NULL,
&sid, &type)) {
type = SID_NAME_UNKNOWN;
}
switch (type) {
case SID_NAME_USER: