1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00

python:tests: pass bytes.decode() instead of str(bytes) to assertMultiLineEqual() to get better failure output

When not equal a diff of the two strings highlighting the differences
will be included this way.

This is a flapping test.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jul 16 07:40:41 UTC 2024 on atb-devel-224
This commit is contained in:
Stefan Metzmacher 2024-07-15 20:14:46 +02:00 committed by Andreas Schneider
parent 6f3545ceca
commit a3856ee4dc

View File

@ -174,7 +174,8 @@ class DCKeytabTests(TestCaseInTempDir):
).communicate()[0]
self.maxDiff = None # No maximum length of diffs.
self.assertMultiLineEqual(str(keytab_orig_content), str(keytab_content))
self.assertMultiLineEqual(keytab_orig_content.decode(),
keytab_content.decode())
# Parse the first entry in the keytab
with open(self.ktfile, 'rb') as bytes_kt: