sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

smbd: call notify_rename() after dropping the lck in rename_internals_fsp()

Browse Source 
Same here, cf the explanation in the previous commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Ralph Boehme 2024-09-06 12:40:43 +02:00
parent d2f50cad70
commit a39d75de30
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source3/smbd/smb2_reply.c
View File

@ -1738,17 +1738,19 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
&rhow);
if (ret == 0) {
uint32_t create_options = fh_get_private_options(fsp->fh);
struct smb_filename *old_fname = NULL;
DBG_NOTICE("succeeded doing rename on "
"%s -> %s\n",
smb_fname_str_dbg(fsp->fsp_name),
smb_fname_str_dbg(smb_fname_dst));
notify_rename(conn,
fsp->fsp_flags.is_directory,
fsp->fsp_name,
smb_fname_dst);
old_fname = cp_smb_filename(talloc_tos(), fsp->fsp_name);
if (old_fname == NULL) {
status = NT_STATUS_NO_MEMORY;
TALLOC_FREE(lck);
goto out;
}
rename_open_files(conn, lck, fsp->file_id, fsp->name_hash,
smb_fname_dst);
@ -1795,7 +1797,15 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
fsp->fsp_flags.initial_delete_on_close = true;
}
}
TALLOC_FREE(lck);
notify_rename(conn,
fsp->fsp_flags.is_directory,
old_fname,
smb_fname_dst);
TALLOC_FREE(old_fname);
status = NT_STATUS_OK;
goto out;
}