sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

py:provision: use canonical representation of ACE flags

Browse Source 
This is because in ceetain places we compare strings rather than security
descriptors.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2023-04-18 11:42:57 +12:00 committed by Andrew Bartlett
parent e521b0a26a
commit a655e7e496
2 changed files with 2 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
python/samba/provision/__init__.py
View File

@ -1598,8 +1598,8 @@ def fill_samdb(samdb, lp, names, logger, policyguid,
return samdb
SYSVOL_ACL = "O:LAG:BAD:P(A;OICI;0x001f01ff;;;BA)(A;OICI;0x001200a9;;;SO)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a9;;;AU)"
POLICIES_ACL = "O:LAG:BAD:P(A;OICI;0x001f01ff;;;BA)(A;OICI;0x001200a9;;;SO)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a9;;;AU)(A;OICI;0x001301bf;;;PA)"
SYSVOL_ACL = "O:LAG:BAD:P(A;OICI;0x1f01ff;;;BA)(A;OICI;0x1200a9;;;SO)(A;OICI;0x1f01ff;;;SY)(A;OICI;0x1200a9;;;AU)"
POLICIES_ACL = "O:LAG:BAD:P(A;OICI;0x1f01ff;;;BA)(A;OICI;0x1200a9;;;SO)(A;OICI;0x1f01ff;;;SY)(A;OICI;0x1200a9;;;AU)(A;OICI;0x1301bf;;;PA)"
SYSVOL_SERVICE = "sysvol"

27
selftest/knownfail.d/sddl-sid-misc
View File

@ -6,10 +6,6 @@
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_invalidate_getntacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_invalidate_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_invalidate_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_policies_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_policies_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_policies_dir_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_policies_dir_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_smbd_getntacl.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_smbd_getntacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_smbd_getntacl_smbd.ad_dc:local
@ -22,10 +18,6 @@
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_smbd_setposixacl_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_smbd_setposixacl_group_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_smbd_setposixacl_group_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_sysvol_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_sysvol_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_sysvol_dir_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setntacl_sysvol_dir_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setposixacl_dir_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setposixacl_dir_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.PosixAclMappingTests.test_setposixacl_getntacl_smbd.ad_dc:local
@ -40,10 +32,6 @@
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_invalidate_getntacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_invalidate_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_invalidate_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_policies_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_policies_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_policies_dir_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_policies_dir_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_smbd_getntacl.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_smbd_getntacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_smbd_getntacl_smbd.ad_dc:local
@ -56,10 +44,6 @@
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_smbd_setposixacl_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_smbd_setposixacl_group_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_smbd_setposixacl_group_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_sysvol_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_sysvol_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_sysvol_dir_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setntacl_sysvol_dir_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setposixacl_dir_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setposixacl_dir_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.SessionedPosixAclMappingTests.test_setposixacl_getntacl_smbd.ad_dc:local
@ -74,10 +58,6 @@
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_invalidate_getntacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_invalidate_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_invalidate_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_policies_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_policies_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_policies_dir_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_policies_dir_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_smbd_getntacl.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_smbd_getntacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_smbd_getntacl_smbd.ad_dc:local
@ -90,10 +70,6 @@
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_smbd_setposixacl_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_smbd_setposixacl_group_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_smbd_setposixacl_group_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_sysvol_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_sysvol_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_sysvol_dir_check_getposixacl.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setntacl_sysvol_dir_check_getposixacl.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setposixacl_dir_getntacl_smbd.ad_dc:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setposixacl_dir_getntacl_smbd.ad_dc_no_nss:local
^samba.tests.posixacl.+.UnixSessionedPosixAclMappingTests.test_setposixacl_getntacl_smbd.ad_dc:local
@ -104,6 +80,3 @@
^samba.tests.samba_tool.ntacl.samba.tests.samba_tool.ntacl.NtACLCmdChangedomsidTestCase.test_s3fs_check.ad_dc:local
^samba.tests.samba_tool.ntacl.samba.tests.samba_tool.ntacl.NtACLCmdGetSetTestCase.test_ntvfs_check.ad_dc:local
^samba.tests.samba_tool.ntacl.samba.tests.samba_tool.ntacl.NtACLCmdGetSetTestCase.test_s3fs_check.ad_dc:local
^samba.tests.samba_tool.ntacl.samba.tests.samba_tool.ntacl.NtACLCmdSysvolTestCase.test_ntvfs_check.ad_dc:local
^samba.tests.samba_tool.ntacl.samba.tests.samba_tool.ntacl.NtACLCmdSysvolTestCase.test_s3fs_check.ad_dc:local
^samba.tests.samba_tool.ntacl.samba.tests.samba_tool.ntacl.NtACLCmdSysvolTestCase.test_with_missing_files.ad_dc:local