sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-24 02:04:21 +03:00
Code

libcli/security: note suboptimality of conditional ACE Contains operators

Browse Source 
The Contains and Any_of operators could use a sorted comparison like
compare_composites_via_sort(), rather than O(n²) nested loops. But
that would involve amount of quite fiddly work that I am not starting
on now.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Nov 27 23:38:13 UTC 2023 on atb-devel-224
This commit is contained in:
Douglas Bagnall 2023-11-25 12:55:09 +13:00 committed by Andrew Bartlett
parent 2eb00c0bba
commit a757a51a26
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcli/security/conditional_ace.c
View File

@ -1960,6 +1960,10 @@ static bool contains_operator(const struct ace_condition_token *lhs,
* *
* Both the lhs or rhs can be solitary objects or composites. * Both the lhs or rhs can be solitary objects or composites.
* This makes it a bit fiddlier. * This makes it a bit fiddlier.
*
* NOTE: this operator does not take advantage of the
* CLAIM_SECURITY_ATTRIBUTE_UNIQUE_AND_SORTED flag. It could, but it
* doesn't.
*/ */
if (lhs->type == CONDITIONAL_ACE_TOKEN_COMPOSITE) { if (lhs->type == CONDITIONAL_ACE_TOKEN_COMPOSITE) {
struct ace_condition_composite candidates = lhs->data.composite; struct ace_condition_composite candidates = lhs->data.composite;