sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

eventlog: don't leak state_path onto talloc tos

Browse Source 
Also check for allocation failures.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
David Disseldorp 2014-11-02 20:21:24 +01:00 committed by Jeremy Allison
parent b75d7ac9cb
commit a852116ab3
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source3/lib/eventlog/eventlog.c
View File

@ -73,7 +73,7 @@ char *elog_tdbname(TALLOC_CTX *ctx, const char *name )
char *file;
char *tdbname;
path = talloc_strdup(ctx, state_path("eventlog"));
path = state_path("eventlog");
if (!path) {
return NULL;
}
@ -84,7 +84,7 @@ char *elog_tdbname(TALLOC_CTX *ctx, const char *name )
return NULL;
}
tdbname = talloc_asprintf(path, "%s/%s", state_path("eventlog"), file);
tdbname = talloc_asprintf(ctx, "%s/%s", path, file);
if (!tdbname) {
talloc_free(path);
return NULL;
@ -372,8 +372,12 @@ ELOG_TDB *elog_open_tdb( const char *logname, bool force_clear, bool read_only )
/* make sure that the eventlog dir exists */
eventlogdir = state_path( "eventlog" );
eventlogdir = state_path("eventlog");
if (eventlogdir == NULL) {
return NULL;
}
ok = directory_create_or_exist(eventlogdir, 0755);
TALLOC_FREE(eventlogdir);
if (!ok) {
return NULL;
}