sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-17 02:05:21 +03:00
Code

fix a bug in enumprinterdrivers

Browse Source 
J.F.
This commit is contained in:
Jean-François Micouleau -
parent 2b0d05d81c
commit a8d04c26da
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source/rpc_server/srv_spoolss_nt.c
View File

@ -3189,8 +3189,10 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
*needed += spoolss_size_printer_driver_info_1(&(driver_info_1[i]));
}
if (!alloc_buffer_size(buffer, *needed))
if (!alloc_buffer_size(buffer, *needed)) {
safe_free(driver_info_1);
return ERROR_INSUFFICIENT_BUFFER;
}
/* fill the buffer with the form structures */
for (i=0; i<*returned; i++)
@ -3199,10 +3201,12 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
new_smb_io_printer_driver_info_1("", buffer, &(driver_info_1[i]), 0);
}
safe_free(list);
safe_free(driver_info_1);
if (*needed > offered)
if (*needed > offered) {
*returned=0;
return ERROR_INSUFFICIENT_BUFFER;
}
else
return NT_STATUS_NO_PROBLEMO;
}
@ -3230,8 +3234,10 @@ static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstri
*needed += spoolss_size_printer_driver_info_2(&(driver_info_2[i]));
}
if (!alloc_buffer_size(buffer, *needed))
if (!alloc_buffer_size(buffer, *needed)) {
safe_free(driver_info_2);
return ERROR_INSUFFICIENT_BUFFER;
}
/* fill the buffer with the form structures */
for (i=0; i<*returned; i++)
@ -3240,10 +3246,12 @@ static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstri
new_smb_io_printer_driver_info_2("", buffer, &(driver_info_2[i]), 0);
}
safe_free(list);
safe_free(driver_info_2);
if (*needed > offered)
if (*needed > offered) {
*returned=0;
return ERROR_INSUFFICIENT_BUFFER;
}
else
return NT_STATUS_NO_PROBLEMO;
}