sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-11-21 12:23:50 +03:00
Code Activity

smbd: Use generate_nonce_buffer() in smbXsrv_open_global_allocate()

Browse Source 
We don't need anything cryptographic for persistent file handle ids

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Volker Lendecke
2023-01-06 16:46:11 +01:00
committed by Stefan Metzmacher
parent e8abe52df2
commit a93d93a97d
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source3/smbd/smbXsrv_open.c
View File

@@ -254,13 +254,9 @@ static NTSTATUS smbXsrv_open_global_allocate(
if (i >= min_tries && last_free != 0) { if (i >= min_tries && last_free != 0) {
id = last_free; id = last_free;
} else { } else {
id = generate_random(); generate_nonce_buffer((uint8_t *)&id, sizeof(id));
} id = MAX(id, 1);
if (id == 0) { id = MIN(id, UINT32_MAX-1);
id++;
}
if (id == UINT32_MAX) {
id--;
} }
key = smbXsrv_open_global_id_to_key(id, &key_buf); key = smbXsrv_open_global_id_to_key(id, &key_buf);