sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-15 05:57:49 +03:00
Code

torture/backupkey: Fix flapping test

Browse Source 
UNEXPECTED(failure): samba4.rpc.backupkey with seal.backupkey.server_wrap_decrypt_wrong_r2(ad_dc_default)
REASON: Exception: Exception: ../../source4/torture/rpc/backupkey.c:2219: r.out.result was WERR_INVALID_ACCESS, expected WERR_INVALID_PARAMETER: decrypt should fail with WERR_INVALID_PARAMETER

As commit 664bde19bf1db1b3740621cdf3f46f9bfd0e8452 states:

"The use of the wrong key can still create structures that parse as a
SID, therefore we can sometimes get an unusual error, which becomes a
flapping test".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12107

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-03-01 11:37:03 +13:00 committed by Andrew Bartlett
parent 264351f5c3
commit aa90354e24
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source4/torture/rpc/backupkey.c
View File

@ -2216,10 +2216,12 @@ static bool test_ServerWrap_decrypt_wrong_stuff(struct torture_context *tctx,
WERR_INVALID_ACCESS,
"decrypt should fail with WERR_INVALID_ACCESS");
} else {
torture_assert_werr_equal(tctx,
r.out.result,
WERR_INVALID_PARAMETER,
"decrypt should fail with WERR_INVALID_PARAMETER");
if (!W_ERROR_EQUAL(r.out.result, WERR_INVALID_ACCESS)
&& !W_ERROR_EQUAL(r.out.result, WERR_INVALID_PARAMETER)) {
torture_assert_werr_equal(tctx, r.out.result,
WERR_INVALID_DATA,
"decrypt should fail with WERR_INVALID_ACCESS, WERR_INVALID_PARAMETER or WERR_INVALID_DATA");
}
}
return true;